Merge pull request #455 from crazy-max/install-deprecated

deprecate install input

.github/workflows/ci.yml

@@ -115,22 +115,6 @@ jobs:
           context: .
           platforms: linux/amd64,linux/arm64,linux/ppc64le
 
-  install:
-    runs-on: ubuntu-latest
-    steps:
-      -
-        name: Checkout
-        uses: actions/checkout@v6
-      -
-        name: Set up Docker Buildx
-        uses: ./
-        with:
-          install: true
-      -
-        name: Check cmd
-        run: |
-          docker build --help
-
   use:
     runs-on: ubuntu-latest
     strategy:

README.md

@@ -94,7 +94,7 @@ The following inputs can be used as `step.with` keys:
 | `buildkitd-flags`            | String   |                    | [BuildKit daemon flags](https://docs.docker.com/engine/reference/commandline/buildx_create/#buildkitd-flags)                                                                |
 | `buildkitd-config` \*        | String   |                    | [BuildKit daemon config file](https://docs.docker.com/engine/reference/commandline/buildx_create/#config)                                                                   |
 | `buildkitd-config-inline` \* | String   |                    | Same as `buildkitd-config` but inline                                                                                                                                       |
-| `install`                    | Bool     | `false`            | Sets up `docker build` command as an alias to `docker buildx`                                                                                                               |
+| `install` \*                 | Bool     | `false`            | Sets up `docker build` command as an alias to `docker buildx`                                                                                                               |
 | `use`                        | Bool     | `true`             | Switch to this builder instance                                                                                                                                             |
 | `endpoint`                   | String   |                    | [Optional address for docker socket](https://docs.docker.com/engine/reference/commandline/buildx_create/#description) or context from `docker context ls`                   |
 | `platforms`                  | List/CSV |                    | Fixed [platforms](https://docs.docker.com/engine/reference/commandline/buildx_create/#platform) for current node. If not empty, values take priority over the detected ones |
@@ -111,6 +111,14 @@ The following inputs can be used as `step.with` keys:
 > [!NOTE]
 > `buildkitd-config` and `buildkitd-config-inline` are mutually exclusive.
 
+> [!NOTE]
+> `install` input is deprecated and will be removed in a future release. This
+>  input is not necessary when building with our actions like
+> `docker/build-push-action` or `docker/bake-action`. If you are still building
+> with the `docker build` command then you can set the `BUILDX_BUILDER`
+> environment variable, or you can just directly invoke the
+> `docker buildx build` command: https://github.com/docker/setup-buildx-action/pull/455
+
 ### outputs
 
 The following outputs are available:

action.yml

@@ -26,10 +26,6 @@ inputs:
   buildkitd-config-inline:
     description: 'Inline BuildKit daemon config'
     required: false
-  install:
-    description: 'Sets up docker build command as an alias to docker buildx build'
-    default: 'false'
-    required: false
   use:
     description: 'Switch to this builder instance'
     default: 'true'
@@ -58,7 +54,7 @@ inputs:
     description: 'Cleanup temp files and remove builder at the end of a job'
     default: 'true'
     required: false
-  # TODO: remove deprecated config and config-inline inputs
+  # TODO: remove deprecated config, config-inline and install inputs
   config:
     description: 'BuildKit daemon config file'
     deprecationMessage: 'Use buildkitd-config instead'
@@ -67,6 +63,11 @@ inputs:
     description: 'Inline BuildKit daemon config'
     deprecationMessage: 'Use buildkitd-config-inline instead'
     required: false
+  install:
+    description: 'Sets up docker build command as an alias to docker buildx build'
+    deprecationMessage: '"docker buildx install" command is deprecated and will be removed in a future release, use BUILDX_BUILDER environment variable instead'
+    default: 'false'
+    required: false
 
 outputs:
   name:

package.json

@@ -25,7 +25,7 @@
   "license": "Apache-2.0",
   "packageManager": "yarn@4.9.2",
   "dependencies": {
-    "@actions/core": "^2.0.1",
+    "@actions/core": "^1.11.1",
     "@docker/actions-toolkit": "^0.63.0",
     "js-yaml": "^4.1.0"
   },

yarn.lock

@@ -70,16 +70,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@actions/core@npm:^2.0.1":
-  version: 2.0.1
-  resolution: "@actions/core@npm:2.0.1"
-  dependencies:
-    "@actions/exec": "npm:^2.0.0"
-    "@actions/http-client": "npm:^3.0.0"
-  checksum: 10/a3376a89886c7144d5db0cd7f897ab397c1f9eaa7b291e052b87d0bd5096e4ccc1046084b26b5d764cb29c7980098c202af8ec3a5928183a8e52d3421c4210f6
-  languageName: node
-  linkType: hard
-
 "@actions/exec@npm:^1.0.0, @actions/exec@npm:^1.0.1, @actions/exec@npm:^1.1.1":
   version: 1.1.1
   resolution: "@actions/exec@npm:1.1.1"
@@ -89,15 +79,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@actions/exec@npm:^2.0.0":
-  version: 2.0.0
-  resolution: "@actions/exec@npm:2.0.0"
-  dependencies:
-    "@actions/io": "npm:^2.0.0"
-  checksum: 10/61f84e3920eaa898edff3a4de97d353bb8f4379ced229128d7c945cd18c02e0d8d33a22629cec7bb7797a5f8879952ee9d291921ffd02bc849e6a7d4e2e3a52a
-  languageName: node
-  linkType: hard
-
 "@actions/github@npm:^5.1.1":
   version: 5.1.1
   resolution: "@actions/github@npm:5.1.1"
@@ -155,16 +136,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@actions/http-client@npm:^3.0.0":
-  version: 3.0.0
-  resolution: "@actions/http-client@npm:3.0.0"
-  dependencies:
-    tunnel: "npm:^0.0.6"
-    undici: "npm:^5.28.5"
-  checksum: 10/7ed597cf91953cb56f74ece13187914fee629cb81cd11357676425388dd239508be63d0eff7930e2b066034f2a86dd24b313c09717f878aaf8ed3f5a6853b816
-  languageName: node
-  linkType: hard
-
 "@actions/io@npm:^1.0.1, @actions/io@npm:^1.1.1, @actions/io@npm:^1.1.3":
   version: 1.1.3
   resolution: "@actions/io@npm:1.1.3"
@@ -172,13 +143,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@actions/io@npm:^2.0.0":
-  version: 2.0.0
-  resolution: "@actions/io@npm:2.0.0"
-  checksum: 10/4f8f98b564fe8974d47f6d9b06721d5bd3034f181be20188554d2ccad530330c218891c4c6f7c3da69883d8e53da513ce335617c0673461d4e064abcc9a6eebb
-  languageName: node
-  linkType: hard
-
 "@actions/tool-cache@npm:^2.0.2":
   version: 2.0.2
   resolution: "@actions/tool-cache@npm:2.0.2"
@@ -3360,7 +3324,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "docker-setup-buildx@workspace:."
   dependencies:
-    "@actions/core": "npm:^2.0.1"
+    "@actions/core": "npm:^1.11.1"
     "@docker/actions-toolkit": "npm:^0.63.0"
     "@types/js-yaml": "npm:^4.0.9"
     "@types/node": "npm:^20.19.9"